Jsonnet: add node_affinity_matchers setting support for every Mimir component #6829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
56quarters
approved these changes
Dec 5, 2023
| @@ -30,6 +30,11 @@ | |||
| mimir_write_zone_b_args:: $.ingester_zone_b_args {}, | |||
| mimir_write_zone_c_args:: $.ingester_zone_c_args {}, | |||
|
|
|||
| mimir_write_node_affinity_matchers:: [], | |||
There was a problem hiding this comment.
This doesn't seem like it's used anywhere?
There was a problem hiding this comment.
The per-zone matchers (lines below) inherit from it. It's handy when you want to set a node affinity matcher for mimir-write regardless the zone.
| @@ -73,16 +75,20 @@ | |||
| $.util.readinessProbe + | |||
| $.jaeger_mixin, | |||
|
|
|||
| newStoreGatewayStatefulSet(name, container, with_anti_affinity=false):: | |||
| newStoreGatewayStatefulSet(name, container, with_anti_affinity=false, nodeAffinityMatchers=[]):: | |||
There was a problem hiding this comment.
I know it's unrelated to this PR but it'd be nice to rename with_anti_affinity to withAntiAffinity to match the other parameters
There was a problem hiding this comment.
Ok. Let me do in a follow up PR.
4 tasks
charleskorn
reviewed
Dec 5, 2023
Comment on lines
+48
to
+49
| * `ruler_node_affinity_matchers` | ||
| * `ruler_node_affinity_matchers` |
There was a problem hiding this comment.
Should this be here twice?
charleskorn
reviewed
Dec 5, 2023
Comment on lines
+53
to
+54
| * `store_gateway_node_affinity_matchers` | ||
| * `store_gateway_node_affinity_matchers` |
There was a problem hiding this comment.
Should this be here twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR is a follow up of #6782. In #6782 I've introduced
distributor_node_affinity_matchersand successfully use it at Grafana Labs to simplify the jsonnet setup. In this PR I'm doing the same for every other Mimir component.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.