Jsonnet / Helm: relax the hash ring heartbeat period and timeout for distributor, ingester, store-gateway and compactor #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitarvdimitrov
commented
Dec 8, 2023
This comment was marked as outdated.
This comment was marked as outdated.
dimitarvdimitrov
force-pushed
the
dimitar/update-ring-settings
branch
from
53d2ce2
to
64e9bef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pracucci
force-pushed
the
dimitar/update-ring-settings
branch
3 times, most recently
from
5f09fa3
to
da29aad
Compare
…ngester, store-gateway and compactor. These are values which help reduce the pressure on a KV store or reduce the CPU spent by memberlist in passing messages. The tradeoff is that abrupt shutdowns/crashes of components will take longer to detect by peers. We've been running with these values at Grafana Labs for some time and haven't seen problems. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
dimitar/update-ring-settings
branch
from
cfb91ca
to
a677f2f
Compare
pracucci
changed the title
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
There was a problem hiding this comment.
thanks for driving this to completion @pracucci. In principle LGTM. Reviewing this code raises questions that I didn't ask myself before 😅
operations/compare-helm-with-jsonnet/components/config/kustomization.yaml
Show resolved
Hide resolved
pracucci
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
I took ownership of this PR from Dimitar. I did the changes on Dimitar's PR, so I've asked Dimitar to review it. Dimitar approved, but can't officially approve its own PR, so I'm approving it (but it's not a self-approval, it's Dimitar approving it in practice).
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we're upstreaming a config change we've done long time ago at Grafana Labs, relaxing the hash ring heartbeat period and timeout for distributor, ingester, store-gateway and compactor.
These are values which help reduce the pressure on a KV store or reduce the CPU spent by memberlist in passing messages.The tradeoff is that abrupt shutdowns/crashes of components will take longer to detect by peers. We've been running with these values at Grafana Labs for some time and haven't seen problems.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.