Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k6: Pass auth to write path via headers not URL #6915

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Dec 12, 2023

What this PR does

This changes the k6 load testing script to pass authentication for remote writes via headers (same as we do for reads) instead of as part of the URL.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • [NA] Tests updated.
  • [NA] Documentation added.
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [NA] about-versioning.md updated with experimental features.

This changes the k6 load testing script to pass authentication for remote
writes via headers (same as we do for reads) instead of as part of the URL.
@56quarters 56quarters marked this pull request as ready for review December 12, 2023 15:29
@56quarters 56quarters requested a review from a team as a code owner December 12, 2023 15:29
Copy link
Contributor

@treid314 treid314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@56quarters 56quarters merged commit 1f903e1 into main Dec 12, 2023
28 checks passed
@56quarters 56quarters deleted the 56quarters/k6-testing branch December 12, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants