Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .metricsUsed in mimirtool analyze rule-file #6953

Merged
merged 3 commits into from Dec 18, 2023

Conversation

colega
Copy link
Contributor

@colega colega commented Dec 18, 2023

This field wasn't populated when rule files were analyzed.

Fixes #6952

Signed-off-by: Oleg Zaytsev mail@olegzaytsev.com

This field wasn't populated.

Fixes #6952

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega marked this pull request as ready for review December 18, 2023 12:56
@colega colega requested a review from a team as a code owner December 18, 2023 12:56
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Copy link
Contributor

@flxbk flxbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colega colega merged commit 6a7bee2 into main Dec 18, 2023
28 checks passed
@colega colega deleted the fix-analyse-rules-metrics-used branch December 18, 2023 15:11
@grafanabot
Copy link
Contributor

The backport to release-2.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6953-to-release-2.11 origin/release-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 6a7bee283bfa4113bbf7f3b028c8f1045afe89b9
# Push it to GitHub
git push --set-upstream origin backport-6953-to-release-2.11
git switch main
# Remove the local backport branch
git branch -D backport-6953-to-release-2.11

Then, create a pull request where the base branch is release-2.11 and the compare/head branch is backport-6953-to-release-2.11.

colega added a commit that referenced this pull request Dec 18, 2023
* Fix .metricsUsed in mimirtool analyze rule-file

This field wasn't populated.

Fixes #6952

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Update CHANGELOG.md

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* make license

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
(cherry picked from commit 6a7bee2)
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega added a commit that referenced this pull request Dec 18, 2023
* Fix .metricsUsed in mimirtool analyze rule-file

This field wasn't populated.

Fixes #6952

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Update CHANGELOG.md

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* make license

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
(cherry picked from commit 6a7bee2)
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega added a commit that referenced this pull request Dec 18, 2023
* Fix .metricsUsed in mimirtool analyze rule-file

This field wasn't populated.

Fixes #6952

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Update CHANGELOG.md

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* make license

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
(cherry picked from commit 6a7bee2)
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega added a commit that referenced this pull request Dec 18, 2023
#6956)

* Fix .metricsUsed in mimirtool analyze rule-file (#6953)

* Fix .metricsUsed in mimirtool analyze rule-file

This field wasn't populated.

Fixes #6952

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Update CHANGELOG.md

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* make license

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
(cherry picked from commit 6a7bee2)
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Update release notes

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mimirtool analyze rule-file doesn't output metricsUsed
3 participants