Refactor Distributor.push()
#6978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted methods, removed needless receivers, moved code to mimirpb. This should not change any logic. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
We already have a WriteRequest allocated, there's no need to create another one. Also the signature is shorter now. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
force-pushed
the
refactor-distributor-push
branch
from
e2be173
to
e5aff2b
Compare
bboreham
approved these changes
Dec 21, 2023
pkg/distributor/distributor.go
Outdated
| return nil | ||
| // getSeriesAndMetadataTokensForBatchRequest returns a slice of tokens for the series and metadata from the request in this specific order. | ||
| // Metadata tokens start at initialMetadataIndex. | ||
| func getSeriesAndMetadataTokensForBatchRequest(userID string, req *mimirpb.WriteRequest) (keys []uint32, initialMetadataIndex int) { |
There was a problem hiding this comment.
What makes it a "BatchRequest" ? This is called with the entire request; I thought the batches were what DoBatch splits it into.
There was a problem hiding this comment.
My reasoning was: since we pass this to ring.DoBatch ... but if this raised you a question, then it's not helping. I'm going to remove the ForBatchRequest suffix from this method.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
dimitarvdimitrov
approved these changes
Dec 21, 2023
Comment on lines
+598
to
+604
| for _, i := range indexes { | ||
| if i >= initialMetadataIndex { | ||
| metadataCount++ | ||
| } else { | ||
| timeseriesCount++ | ||
| } | ||
| } |
There was a problem hiding this comment.
can't we do this with binary search?
There was a problem hiding this comment.
We could, but it's not necessarily faster. We'd need a benchmark, and I need to stop somewhere :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Makes
Distributor.pushshorter and hopefully cleaner.Which issue(s) this PR fixes or relates to
None.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.