Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Slow Queries" dashboard: make more fields sortable #7000

Merged
merged 8 commits into from
Dec 28, 2023
Merged

"Slow Queries" dashboard: make more fields sortable #7000

merged 8 commits into from
Dec 28, 2023

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Dec 26, 2023 •
edited

This PR dusts off the Slow queries dashboard. it contains a couple of minor usability changes

  • org_id label renamed to user
  • Time span, Step, Duration fields are now parsed as time duration in seconds and can be properly sorted by (e.g. 2.1 s)
  • bytes columns display as an IEC byte unit and can be sorted by (e.g. 1GiB)
  • chunks and series counts are displayed as short numbers (e.g. 1.2K, 15M)
  • reorder status and err as earlier columns
  • add human-friendly names to a few parameters (Error, Start, End, Time, Completion date)
  • convert all numeric fields to numbers so they can be sorted by

@dimitarvdimitrov
"Slow Queries" dashbaord: make numeric fields sortable
2006ccc 
In addition to making numeric fields sortable, this PR
* adds the duration of the query as a number in seconds, so it can be sorted by
* and removes two non-interesting fields from the table

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner December 26, 2023 13:36
@dimitarvdimitrov
Add CHANGELOG.md entry
17fb77f 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov changed the title "Slow Queries" dashbaord: make numeric fields sortable "Slow Queries" dashboard: make numeric fields sortable Dec 26, 2023
@dimitarvdimitrov
Update helm manifests
c87b27c 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov
Another update
63c6a0c 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov changed the title "Slow Queries" dashboard: make numeric fields sortable "Slow Queries" dashboard: make more fields sortable Dec 26, 2023
@dimitarvdimitrov
Add override for Error too
805c663 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov
Copy link
Contributor Author

dimitarvdimitrov commented Dec 26, 2023 •
edited

That's how the panel ended up looking like
Screenshot 2023-12-26 at 15 19 59

@dimitarvdimitrov
Add more units
8b2a543 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov
Update changelo
47d0eb6 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov
Make durations sortable too
2877e38 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
ying-jeanne
ying-jeanne approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@ying-jeanne ying-jeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the change work as expected. LGTM

@ying-jeanne ying-jeanne merged commit 9dec543 into main Dec 28, 2023
30 checks passed
@ying-jeanne ying-jeanne deleted the dimitar/mixin/slow-queries-number-fields branch December 28, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ying-jeanne ying-jeanne ying-jeanne approved these changes

Assignees
No one assigned
Labels
mixin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimitarvdimitrov @ying-jeanne