[query-frontend] Set http request headers from querymiddleware request options #7033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxbk
force-pushed
the
felix/fix-encode-request
branch
from
3e3b460
to
6898e5d
Compare
colega
approved these changes
Jan 3, 2024
dimitarvdimitrov
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
prometheusCodecprovides the methodsDecodeRequestandEncodeRequestto convert from anhttp.Requestto aquerymiddleware.Requestand back. The conversion from an http request sets values in the request options, but these are not considered for the conversion back to an http request. As a consequence, the http request obtained by decoding and re-encoding is not equivalent to the original request in cases where custom headers were present on the initial request.This PR adds http headers equivalent to the request options to fix this.
Which issue(s) this PR fixes or relates to
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.