Write query parameters to span attributes instead of events #7046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chencs
force-pushed
the
casie/write-query-data-to-span-tags
branch
from
e52e325
to
6036e0f
Compare
chencs
force-pushed
the
casie/write-query-data-to-span-tags
branch
from
d671443
to
ed25794
Compare
dimitarvdimitrov
approved these changes
Jan 19, 2024
chencs
force-pushed
the
casie/write-query-data-to-span-tags
branch
from
ed25794
to
0d3eb1f
Compare
chencs
force-pushed
the
casie/write-query-data-to-span-tags
branch
from
0d3eb1f
to
439a0a2
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Currently, it's next to impossible to use Tempo's TraceQL to search for traces on specific queries, as TraceQL doesn't support searching on event attributes. Here is a related comment pointing out this pain for Mimir.
Since query params aren't really an event in time, and therefore don't benefit from the timestamp that span events/logs require, I propose that instead of logging query parameters as span events, we store them as span attributes (a.k.a. "tags"). This will make traces searchable by query information (e.g., query string and step size) via TraceQL, and removes some span logs whose timing has no significance.
Which issue(s) this PR fixes or relates to
Relates to grafana/tempo#2313
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.