new Mimir / Reads dashboard panel for scheduler queue duration, breakout by additional queue dimensions #7059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoposa
commented
Jan 5, 2024
| @@ -1002,6 +1002,42 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |||
| { yaxes: $.yaxes('percentunit') } | |||
| ), | |||
|
|
|||
| latencyPanelLabelBreakout(metricName, selector, labels=[], labelReplaceArgSets=[{}], multiplier='1e3'):: | |||
There was a problem hiding this comment.
This is just a version of the latencyPanel in the upstream grafana.libsonnet. - Will try to upstream it if we like it here
francoposa
commented
Jan 5, 2024
francoposa
commented
Jan 5, 2024
francoposa
changed the title
|
In the interest of having fewer rows have you considered removing the text panel with the description? We can have the help text |
…panel to panel description; better jsonnet usage
|
I like that - took your advice, looks like so: |
dimitarvdimitrov
approved these changes
Jan 8, 2024
|
yep, will do |
francoposa
deleted the
francoposa/mimir-reads-dashboard-query-scheduler-queue-duration-breakout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have not figured out how to show the actual panel in the dashboards, because the metamonitoring helm chart seems to have the scrape interval too wide to graph with
[$__rate_interval], but if I open the panel in explore and hardcode the rate interval to to[10m]it looks like:What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.