Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default CPU limit for rollout-operator pod #7066

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jan 8, 2024

What this PR does

This PR removes the CPU limit for rollout-operator pods created by Jsonnet.

This limit is not needed and unnecessarily limits the CPU utilisation of the rollout-operator under load.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, I know some people run with linters/admission controllers in their k8s clusters to block pods without a resource limit from running. Hopefully they aren't that many 🤞 😄

@charleskorn charleskorn marked this pull request as ready for review January 8, 2024 22:56
@charleskorn charleskorn requested a review from a team as a code owner January 8, 2024 22:56
@charleskorn charleskorn merged commit 457bfc4 into main Jan 8, 2024
28 checks passed
@charleskorn charleskorn deleted the charleskorn/remove-rollout-operator-cpu-limit branch January 8, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants