Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MAINTAINERS.md #7077

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Update MAINTAINERS.md #7077

merged 3 commits into from
Jan 19, 2024

Conversation

derek-cadzow
Copy link
Contributor

What this PR does

Removes departed employee and substitutes my own ID (Derek Cadzow) until a backfill is in place.
(Jack: not sure I should be a maintainer over the long term - can we discuss? Is this a good idea?)

@derek-cadzow derek-cadzow requested a review from a team as a code owner January 8, 2024 21:32
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts are that it makes sense to remove Ursula because I do not believe she will be continuing to maintain these docs.

I would not add yourself as a maintainer unless you intend to be added to the @grafana/docs-metrics team and take up the responsibilities of maintainership. Primarily, that is reviewing PRs that affect the files owned by @grafana/docs-metrics

@derek-cadzow
Copy link
Contributor Author

derek-cadzow commented Jan 10, 2024 via email

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case @derek-cadzow I think my suggestion does what you want and if you accept it, we can close and merge this PR.

MAINTAINERS.md Outdated Show resolved Hide resolved
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry merged commit 8241204 into main Jan 19, 2024
28 checks passed
@jdbaldry jdbaldry deleted the derek-cadzow-patch-1 branch January 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants