Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CHANGELOG.md for next helm release #7079

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

flxbk
Copy link
Contributor

@flxbk flxbk commented Jan 9, 2024

What this PR does

This prepares the changelog for the next Helm release.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@flxbk flxbk force-pushed the felix/prepare-helm-changelog branch from c8bf5c8 to 609d708 Compare January 9, 2024 08:56
@flxbk flxbk marked this pull request as ready for review January 9, 2024 08:57
@flxbk flxbk requested a review from a team as a code owner January 9, 2024 08:57
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of not pushing out too many major releases (and discouraging people from upgrading), I think we should do a minor release instead of a major one.

we've had an epic with ideas for the breaking changes in the helm chart in #4560. I think #2865 is the most important one we want to include in 6.0 and we still haven't made progress on it

Would be nice to hear what @krajorama and perhaps @Logiraptor think about this.

@flxbk flxbk changed the title Prepare CHANGELOG.md for helm release 6.0.0 Prepare CHANGELOG.md for next helm release Jan 9, 2024
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please follow the release process and target main branch with this PR to "cut" the release. The helm chart has its own release branches. To be merged back to main as usual.

I noticed because 5.1.4 wasn't here.

@flxbk flxbk changed the base branch from release-2.11 to main January 9, 2024 13:05
@flxbk flxbk marked this pull request as draft January 9, 2024 13:05
@flxbk flxbk force-pushed the felix/prepare-helm-changelog branch from f53758e to 9fd6efb Compare January 9, 2024 13:10
@flxbk flxbk marked this pull request as ready for review January 9, 2024 13:11
@flxbk flxbk merged commit 4f43161 into main Jan 9, 2024
30 checks passed
@flxbk flxbk deleted the felix/prepare-helm-changelog branch January 9, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants