Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query-scheduler queue length to Reads and Remote Ruler Reads dashboards #7088

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jan 10, 2024

What this PR does

This PR adds an additional panel to the Reads and Remote Rule Reads dashboards, showing the query-scheduler queue length:

Screenshot 2024-01-11 at 5 13 14 pm

This is useful when responding to the MimirSchedulerQueriesStuck alert, as the alert is based on the queue length, which is not currently shown on these dashboards.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review January 10, 2024 06:34
@charleskorn charleskorn requested review from a team as code owners January 10, 2024 06:34
duricanikolic
duricanikolic previously approved these changes Jan 10, 2024
Copy link
Contributor

@duricanikolic duricanikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charleskorn charleskorn force-pushed the charleskorn/query-scheduler-queue-length branch from b4b67aa to c98d930 Compare January 11, 2024 06:09
@charleskorn charleskorn merged commit accc1f2 into main Jan 14, 2024
30 checks passed
@charleskorn charleskorn deleted the charleskorn/query-scheduler-queue-length branch January 14, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants