Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: include gRPC status code validation only when running ingester #7095

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

dimitarvdimitrov
Copy link
Contributor

The current validation added in #6940 also applies to the distributor and ends up blocking distributor startup unnecessarily.

The current validation also applies to the distributor and ends up blocking distributor startup unnecessarily.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner January 10, 2024 16:51
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitarvdimitrov dimitarvdimitrov merged commit a9f5689 into main Jan 10, 2024
28 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/ingest/grpc-errors-validation branch January 10, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants