Add additional querier metrics #7099
Conversation
Adds metrics to: - count how many queries are executed in total for a particular source: ingesters vs store gateways - count the total chunks read from a store gateway
| @@ -135,6 +137,11 @@ func newBlocksStoreQueryableMetrics(reg prometheus.Registerer) *blocksStoreQuery | |||
| Name: "cortex_querier_blocks_with_compactor_shard_but_incompatible_query_shard_total", | |||
| Help: "Blocks that couldn't be checked for query and compactor sharding optimization due to incompatible shard counts.", | |||
| }), | |||
| // Named to be consistent with distributor_query_ingester_chunks_total | |||
There was a problem hiding this comment.
This metric is very similar to the metrics in query_metrics.go, but those are mostly specific to ingesters/distributors and not as easy to share with a block store queryable, so I followed the precedent of keeping the ingester and store gateway metrics in queriers separate.
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
| @@ -135,6 +137,11 @@ func newBlocksStoreQueryableMetrics(reg prometheus.Registerer) *blocksStoreQuery | |||
| Name: "cortex_querier_blocks_with_compactor_shard_but_incompatible_query_shard_total", | |||
| Help: "Blocks that couldn't be checked for query and compactor sharding optimization due to incompatible shard counts.", | |||
| }), | |||
| // Named to be consistent with distributor_query_ingester_chunks_total | |||
| chunksTotal: promauto.With(reg).NewCounter(prometheus.CounterOpts{ | |||
| Name: "cortex_query_storegateway_chunks_total", | |||
There was a problem hiding this comment.
The querier metrics are prefixed by cortex_querier_. WDYT if we change the metric name to cortex_querier_query_storegateway_chunks_total?
There was a problem hiding this comment.
That name sounds good. Pushed PR #7145
| @@ -135,6 +137,11 @@ func newBlocksStoreQueryableMetrics(reg prometheus.Registerer) *blocksStoreQuery | |||
| Name: "cortex_querier_blocks_with_compactor_shard_but_incompatible_query_shard_total", | |||
| Help: "Blocks that couldn't be checked for query and compactor sharding optimization due to incompatible shard counts.", | |||
| }), | |||
| // Named to be consistent with distributor_query_ingester_chunks_total | |||
There was a problem hiding this comment.
Nit: the metric is named cortex_distributor_query_ingester_chunks_total (with cortex_ prefix).
There was a problem hiding this comment.
This is really a nit, not worth a PR, but if you address the other comment then you could fix this too.
What this PR does
Adds metrics to:
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.