Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimirpb: add DeepCopyTimeseries extra option to make a deep copy hi… #7130

Merged

Conversation

ortuman
Copy link
Contributor

@ortuman ortuman commented Jan 15, 2024

This PR adds an extra option to specify whether we want to deep copy timeseries histogram samples when invoking DeepCopyTimeseries.

@ortuman ortuman requested a review from a team as a code owner January 15, 2024 14:43
@ortuman ortuman force-pushed the ortuman/mimir-deep-copy-timeseries-keep-histograms-option branch 2 times, most recently from c1e851a to 262f92b Compare January 15, 2024 15:08
…stogram samples

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
@ortuman ortuman force-pushed the ortuman/mimir-deep-copy-timeseries-keep-histograms-option branch from 262f92b to 6c46049 Compare January 15, 2024 15:17
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ortuman ortuman enabled auto-merge (squash) January 15, 2024 15:29
@ortuman ortuman merged commit 0ce85d3 into main Jan 15, 2024
28 checks passed
@ortuman ortuman deleted the ortuman/mimir-deep-copy-timeseries-keep-histograms-option branch January 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants