Set -server.grpc.num-workers=100 by default #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the `-server.grpc.num-workers` to 100 by default, and changes the category of that flag to `advanced`. This is the value we've tested in Grafana Cloud for a while. We've observed an improvement of around 5% in ingester CPU compared to running without this flag set. Note that this is not a limit, but the number of pre-allocated long-lived workers. When all workers are busy, a new goroutine will be spawned (previous default behaviour). Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This sets the
-server.grpc.num-workersto 100 by default, and changes the category of that flag toadvanced.This is the value we've tested in Grafana Cloud for a while. We've observed an improvement of around 5% in ingester CPU compared to running without this flag set.
Note that this is not a limit, but the number of pre-allocated long-lived workers. When all workers are busy, a new goroutine will be spawned (previous default behaviour).
Which issue(s) this PR fixes or relates to
There was no public issue for this.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.