Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: simplify runAsync() and runAsyncAfter() usage in ingest storage tests #7147

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

A chore PR to slightly simplify runAsync() and runAsyncAfter() usage in ingest storage tests. Now, these functions directly add themselves to the sync.WaitGroup.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…e tests

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review January 17, 2024 09:32
@pracucci pracucci requested a review from a team as a code owner January 17, 2024 09:32
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pracucci pracucci merged commit ac3cb58 into main Jan 17, 2024
28 checks passed
@pracucci pracucci deleted the chore-simplify-ingest-storage-unit-tests branch January 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants