Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest storage local dev env: configure Mimir components to start after Kafka is healthy #7153

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

While working on #7142 and testing it locally using development/mimir-ingest-storage I frequently get mimir-write not starting successfully because Kafka is not ready after all the retries done by the Kafka reader (error: failed to fetch last committed offset). A simple solution looks configuring Mimir to wait until Kafka is ready, which is what I do in this PR (tested and fixes the problem).

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…er Kafka is healthy

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i used something like this locally https://stackoverflow.com/a/54824927/5683949, but if this version also works, LGTM


Also - the distributors and ingesters should retry and reconnect to a broker if it's unavailable, right? Do you know why they crash instead?

@pracucci
Copy link
Collaborator Author

the distributors and ingesters should retry and reconnect to a broker if it's unavailable, right? Do you know why they crash instead?

Ingesters fail the starting() if Kafka reader can't get the last committed offset after all the retries (and so the error: failed to fetch last committed offset).

@pracucci pracucci marked this pull request as ready for review January 17, 2024 15:32
@pracucci pracucci requested a review from a team as a code owner January 17, 2024 15:32
@pracucci pracucci merged commit 4fbea7c into main Jan 17, 2024
28 checks passed
@pracucci pracucci deleted the fix-ingest-storage-local-dev-env branch January 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants