Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest dskit for cache changes #7155

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

56quarters
Copy link
Contributor

What this PR does

Specifically pulls in grafana/dskit#466 which changes the RemoteCacheClient interface and Memcached/Redis implementations of it, removing an impossible error return.

Which issue(s) this PR fixes or relates to

Related to grafana/dskit#466

Checklist

  • Tests updated.
  • [NA] Documentation added.
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [NA] about-versioning.md updated with experimental features.

Specifically pulls in grafana/dskit#466 which changes the `RemoteCacheClient`
interface and Memcached/Redis implementations of it, removing an impossible
error return.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review January 17, 2024 15:57
@56quarters 56quarters requested review from grafanabot and a team as code owners January 17, 2024 15:57
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@56quarters 56quarters merged commit a56442d into main Jan 17, 2024
28 checks passed
@56quarters 56quarters deleted the 56quarters/dskit-cache-update branch January 17, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants