Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimir-mixin: drop unsupported step target parameter #7157

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

krajorama
Copy link
Contributor

@krajorama krajorama commented Jan 18, 2024

What this PR does

Update dashboards to drop unsupported step parameter in query targets.

Updates jsonnet-libs dependency to grafana/jsonnet-libs@3d58bd5 to get grafana/jsonnet-libs#1128

Which issue(s) this PR fixes or relates to

Related to #7152
Related to grafana/jsonnet-libs#1128

Checklist

  • N/A Tests updated.
  • N/A Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • N/A about-versioning.md updated with experimental features.

Brings in grafana/jsonnet-libs#1128

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama requested a review from a team as a code owner January 18, 2024 08:23
@krajorama krajorama marked this pull request as draft January 18, 2024 08:24
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama marked this pull request as ready for review January 18, 2024 08:32
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, thanks 😄 LGTM

@krajorama krajorama merged commit 9bb0752 into main Jan 18, 2024
30 checks passed
@krajorama krajorama deleted the krajo/fix branch January 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants