Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented ingeter migration to spread-minimizing tokens #7174

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

duricanikolic
Copy link
Contributor

What this PR does

This PR adds a documentation on how to migrate ingesters to spread-minimizing tokens.

Which issue(s) this PR fixes or relates to

Part of #4736

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@duricanikolic duricanikolic added the type/docs Improvements or additions to documentation label Jan 19, 2024
@duricanikolic duricanikolic self-assigned this Jan 19, 2024
@duricanikolic duricanikolic requested review from a team as code owners January 19, 2024 16:31
@duricanikolic duricanikolic force-pushed the yuri/spread-minimizing-doc branch 2 times, most recently from f2600ff to d691044 Compare January 22, 2024 09:39
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from technical point of view, this matches my understanding and the doc I've reviewed before.

@knylander-grafana
Copy link
Contributor

knylander-grafana commented Jan 22, 2024

@duricanikolic Thank you for submitting some documentation. I checked out your PR to do a local build. The page isn't showing up in the local build. I'm going to troubleshoot locally and hopefully fix the issue.

Update: Issue is fixed. I did my suggested edits while I had the page checked out. I'll leave comments where I made changes.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some wording changes and marked what I did in the PR. I also found some additional mistaskes that I introduced. I've left them as suggestions so you can see where I made changes.

Please let me know if you have any questions. I'm happy to explain.

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
@duricanikolic
Copy link
Contributor Author

I made some wording changes and marked what I did in the PR. I also found some additional mistaskes that I introduced. I've left them as suggestions so you can see where I made changes.

Please let me know if you have any questions. I'm happy to explain.

Thank you very much @knylander-grafana. I have applied your suggestions, and will merge the PR.

@duricanikolic duricanikolic merged commit 911fd26 into main Jan 22, 2024
28 checks passed
@duricanikolic duricanikolic deleted the yuri/spread-minimizing-doc branch January 22, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants