Improve read consistency observability #7193
Conversation
| // Get details about the rule. | ||
| detail := rules.FromOriginContext(ctx) | ||
|
|
||
| // If the rule has dependencies then we should enforce strong read consistency, | ||
| // otherwise we'll fallback to the per-tenant default. | ||
| if !detail.NoDependencyRules { | ||
| spanLog := spanlogger.FromContext(ctx, logger) | ||
| spanLog.DebugLog("msg", "forced strong read consistency because the rule depends on other rules in the same rule group") |
There was a problem hiding this comment.
Would adding a tag / attribute to the span help so that we could query by it?
There was a problem hiding this comment.
Is e3525fb what you had in mind?
pkg/ruler/rule_query_consistency.go
Outdated
| // detect that the query is querying the ALERTS_FOR_STATE metric, otherwise we don't inject any specific read | ||
| // consistency level and we fallback to the tenant's default. |
There was a problem hiding this comment.
should the falling back happen in this function or the caller is responsible for it?
There was a problem hiding this comment.
I think none of them. The fallback means "do not explicitly set the read consistency" which is what this function does.
There was a problem hiding this comment.
Falling back to the default happens in the ingester, not in the ruler. Maybe i'm nitpicking too much for a comment.
There was a problem hiding this comment.
I see what you mean now. Let me rephrase the comment.
There was a problem hiding this comment.
I rephrased it here: 61c6917
… available Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
improve-read-consistency-observability
branch
from
a6fd430
to
e3525fb
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
What this PR does
This PR is part of the experimental ingest storage. In this PR I've done a couple of improvements to read consistency observability:
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.