Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: allow to configure ruler-querier max skew separately from querier #7204

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

I have an use where I need to set the ruler-querier max skew differently than the querier. Right now they're coupled together. In this PR I propose to add a dedicated config option for the ruler-querier.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…erier

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review January 24, 2024 13:57
@pracucci pracucci requested a review from a team as a code owner January 24, 2024 13:57
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I guess you'll need to regenerate yaml files.

@pstibrany
Copy link
Member

pstibrany commented Jan 24, 2024

lgtm. I guess you'll need to regenerate yaml files.

actually, since there is no change, that's not true. But you may want to add new or modify existing test to use the new config option.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci
Copy link
Collaborator Author

lgtm. I guess you'll need to regenerate yaml files.

actually, since there is no change, that's not true. But you may want to add new or modify existing test to use the new config option.

Good point. Done in cac7cff

$ diff operations/mimir-tests/test-all-components-generated.yaml operations/mimir-tests/test-all-components-with-custom-max-skew-generated.yaml

563c563
<         maxSkew: 1
---
>         maxSkew: 2
659c659
<         maxSkew: 1
---
>         maxSkew: 2
738c738
<         maxSkew: 1
---
>         maxSkew: 2
903c903
<         maxSkew: 1
---
>         maxSkew: 2

@pracucci pracucci enabled auto-merge (squash) January 24, 2024 14:13
@pracucci pracucci merged commit a7ce333 into main Jan 24, 2024
28 checks passed
@pracucci pracucci deleted the allow-to-fine-tune-ruler-querier-max-skew branch January 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants