Add Dockerfile for tools/copyblocks #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
aknuds1
approved these changes
Jan 25, 2024
| EXPOSE 8080 | ||
| ENTRYPOINT ["/copyblocks"] | ||
|
|
||
| ARG revision |
There was a problem hiding this comment.
[Nit] Is there a reason for this being lowercase unlike the other args?
There was a problem hiding this comment.
Not really. That's what Makefile and all other Dockerfiles use. We could change it if needed, but it's unrelated to this PR.
|
Will wait with merge until the repository is ready. Moving to draft until then. |
New repository now exists, and deployment was tested in #7226. |
|
We can now see first weekly build in the repository as well: r275-f941f47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds Dockerfile for
tools/copyblocks. This allows manual builds of docker image, eg.:or
This also enabled building of docker image during releases or weekly builds.
(Asked internal IT to create new grafana/copyblocks repository for this to work.)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.