Extensible "Rollout progress" workload grouping #7228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some cells where we have multiple deployments (10+) for the same workload. They make the rollout progress dashboard unreadable. In this PR I'm extracting the `label_replace(...)` calls from the "Rollout progress" panel into an array in the config, so users can extend that with their workload matchers. I also used this opportunity to: - Replace `cortex_service` label with `workload`. - Change query from regexp-matching on the metric name to kube_statefulset_... or kube_deployment_...: this is required for Adaptive Metrics to correctly process this metric name lookup. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
|
There's no user-facing change with the default config, so I'm not sure if this worth a CHANGELOG.md entry. 🤔 |
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We have some cells where we have multiple deployments (10+) for the same workload. They make the rollout progress dashboard unreadable.
In this PR I'm extracting the
label_replace(...)calls from the "Rollout progress" panel into an array in the config, so users can extend that with their workload matchers.I also used this opportunity to:
cortex_servicelabel withworkload.With default configuration, this doesn't make any user-facing change.
Which issue(s) this PR fixes or relates to
Fixes an internal report.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.