Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about-grafana-mimir-architecture #7234

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Update about-grafana-mimir-architecture #7234

merged 1 commit into from
Jan 31, 2024

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Jan 26, 2024

What this PR does

While reading through the docs, I've bumped into this phrase, that doesn't look right to me.

The location of the filesystem and the location of the local TSDB blocks cannot be decoupled.

I don't understand what "the location of the filesystem" could mean, in the context of the document. I wonder if maybe this is a typo.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@narqo narqo requested review from a team as code owners January 26, 2024 20:49
@jhalterman jhalterman added the type/docs Improvements or additions to documentation label Jan 27, 2024
@jhalterman
Copy link
Member

The change makes sense to me, but will defer to a doc writer.

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, much clearer and more correct.

@56quarters 56quarters merged commit 3bb7b7f into main Jan 31, 2024
30 checks passed
@56quarters 56quarters deleted the narqo-patch-1 branch January 31, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants