Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query-frontend activity log enhancements #7400

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

pstibrany
Copy link
Member

What this PR does

This PR enhances format of activity log entries produced by query-frontend. I investigated a problem today using these logs, and I had to check the code to understand what the initial number means, especially because it was very short (it turned out to be tenantID). I'm also adding User-Agent header to the activity log, as this would have helped me to pinpoint the problem faster.

Before:

572 POST /prometheus/api/v1/query_range end=1707955800&query=count...

After:

user:572 UA:our-internal-query-tool POST /prometheus/api/v1/query_range end=1707955800&query=count...

Checklist

  • Tests updated.
  • [na] Documentation added.
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [na] about-versioning.md updated with experimental features.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany requested a review from a team as a code owner February 16, 2024 09:46
Copy link
Contributor

@ortuman ortuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@pstibrany pstibrany merged commit 22a8cfe into main Feb 16, 2024
28 checks passed
@pstibrany pstibrany deleted the add-user-agent-to-activity-log branch February 16, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants