Set series cache TTL different based on block metadata #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/diff-block-ttl
branch
4 times, most recently
from
750e359
to
cc4c0e4
Compare
Instead of using a default TTL of 7d for all index-cache related entries, pick different TTLs based on metadata about the block. This allows entries related to blocks that will be deleted (OOO blocks, 2h, 12h) to expire and be eligible to be evicted sooner than they would otherwise. This change only sets different TTLs for series entries in the cache since they account for most of the space in the cache. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/diff-block-ttl
branch
from
cc4c0e4
to
12f13e6
Compare
jhalterman
reviewed
Feb 21, 2024
jhalterman
approved these changes
Feb 21, 2024
pracucci
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Not approving just because I only reviewed BlockTTL(). I defer to @jhalterman proper review for the rest.
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
jhalterman
approved these changes
Feb 21, 2024
pracucci
approved these changes
Feb 22, 2024
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
2 tasks
56quarters
added a commit
that referenced
this pull request
Mar 4, 2024
Like #7407, use different TTL for postings based on block metadata. Use shorter TTLs for cache entries associated with temporary blocks that will be compacted and deleted shortly. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
that referenced
this pull request
Mar 5, 2024
Like #7407, use different TTL for postings based on block metadata. Use shorter TTLs for cache entries associated with temporary blocks that will be compacted and deleted shortly. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Instead of using a default TTL of 7d for all index-cache related entries, pick different TTLs based on metadata about the block. This allows entries related to blocks that will be deleted (OOO blocks, 2h, 12h) to expire and be eligible to be evicted sooner than they would otherwise.
This change only sets different TTLs for series entries in the cache since they account for most of the space in the cache.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.