Require ingester zone to be configured when running ingest storage #7432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitarvdimitrov
approved these changes
Feb 20, 2024
pkg/ingester/ingester_ring.go
Outdated
| // Ingest storage requires the zone to be configured for ingesters, because on the read path we always use | ||
| // zone-aware replication tracker to compute the quorum. | ||
| if ingestStorageEnabled && cfg.InstanceZone == "" { | ||
| return errors.New("the ingester instance zone must be configured when running Mimir with the ingest storage") |
There was a problem hiding this comment.
do we have a more exact cli config name we can give in this error, so it's easier to fix? maybe we can mention both the ingest storage and the ring zone config
There was a problem hiding this comment.
Sure, done in 5dad7ba
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
validate-ingester-zone-with-ingest-storage-is-enabled
branch
from
8aae680
to
5dad7ba
Compare
The reason why I've done the validation in |
pracucci
deleted the
validate-ingester-zone-with-ingest-storage-is-enabled
branch
|
oh, ok you already found that out and reverted the PR 🐌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The ingest storage requires the zone to be configured on ingesters. It's a requirement on the read path, because we always use the zone-aware tracker to handle read-path quorum. In this PR I propose to add a config validation check.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.