Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add estimated compaction jobs based on bucket-index to Mimir dashboards #7449

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Feb 23, 2024

What this PR does

This PR adds estimated compaction jobs based on bucket-index to Mimir dashboards:

  • Compactor
  • Tenant
  • Top Tenants
Compactor
image
Tenant
tenant dashboard
Top Tenants
top tenants

Checklist

  • [na] Tests updated.
  • [na] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [na] about-versioning.md updated with experimental features.

@pstibrany pstibrany marked this pull request as ready for review February 23, 2024 11:48
@pstibrany pstibrany requested a review from a team as a code owner February 23, 2024 11:48
…shboard, and Tenant dashboard.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a curious question what the estimation is and how reliable it is

Comment on lines +245 to +246
Estimated number of compaction jobs based on latest version of bucket index. Ingesters upload new blocks every 2 hours (shortly after 01:00 UTC, 03:00 UTC, 05:00 UTC, etc.),
and compactors should process all of them within 2h interval. If this graph regularly goes to zero (or close to zero) in 2 hour intervals, then compaction works as designed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any "gotchas" around the estimation? My understanding is that it's only delayed, but in general the number there was true at some point in the past, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that it's only delayed, but in general the number there was true at some point in the past, right?

  • Yes, "delay" or bucket-index not being 100% up-to-date is one reason.
  • Additionally, when computing this number, we only consider jobs that can be executed at given moment. But there are typically more jobs -- however they are blocked. For example job for merging blocks in time range 02:00 -- 04:00 is blocked until all "split" jobs for this time range have finished. Only "split" jobs would be counted toward the estimate and those "merge" jobs would not.
  • Another is that when this is computed, there may be ongoing compaction jobs (perhap.

So it's safe to say that computed number was the minimum number of jobs at some recent point in time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was going to suggest to include this in the panel descriptions so it's easier to know how reliable this is and to also explain things like the split/merge jobs shadowing (finished split jobs actually creating more merge jobs)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can update the description.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being done here: #7481

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany enabled auto-merge (squash) February 26, 2024 09:48
@pstibrany pstibrany merged commit 0b2b4c6 into main Feb 26, 2024
30 checks passed
@pstibrany pstibrany deleted the compaction-jobs-panels branch February 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants