Revert "fix(deps): update github.com/thanos-io/objstore digest to a8d75c5 (main)" #7459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 101bfc2.
flxbk
deleted the
revert-7351-deps-update/main-github.com-thanos-io-objstore-digest
branch
grafanabot
pushed a commit
that referenced
this pull request
Feb 26, 2024
flxbk
added a commit
that referenced
this pull request
Feb 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7351.
The above PR introduced thanos-io/objstore#86, which changes authentication behaviour for GCS to set
option.WithoutAuthenticationwhenever a service account is not configured for the bucket client (diff). As a consequence, auth config set viaGOOGLE_APPLICATION_CREDENTIALSis ignored.