Querier: improve merging of batchStream objects #7478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
force-pushed
the
yuri/native-histograms-benchmarks-next-step
branch
4 times, most recently
from
6376a74
to
cd87968
Compare
krajorama
reviewed
Feb 29, 2024
krajorama
reviewed
Mar 1, 2024
duricanikolic
force-pushed
the
yuri/native-histograms-benchmarks-next-step
branch
2 times, most recently
from
be4bf10
to
7154358
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/native-histograms-benchmarks-next-step
branch
from
7154358
to
53c242a
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR refactors
batchStreamtype, which represents a stream ofchunk.Batchobjects which are sorted by their timestamps.In particular:
HasNext(),Next(),AtTime(),At(),AtHistogram()andAtFloatHistograms()are defined on thechunk.Batchtype.batch.batchStreamis not a slice ofchunk.Batchs anymore, but a struct.batch.mergeStreams()has been replaced with a methodmerge()defined onbatch.batchStreamtype.mergeIteratorhas been simplified by removing different unnecessary attributes. This could be achieved thanks to the refactoring done inbatch.batchStreamtype.Which issue(s) this PR fixes or relates to
Part of #7427
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.