Make persistence of sparse headers default behavior #7535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/always-sparse
branch
from
8de35d1
to
b12b394
Compare
Remove the experimental flag to enable / disable persistence of sparse index-headers since the only behavior now is to persist them. The sparse versions have resulted and a huge performance improvement during lazy loading and there's no reason to not enable this behavior. See #7521 (comment) Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/always-sparse
branch
from
16fcaa7
to
be2ef27
Compare
dimitarvdimitrov
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
awesome, LGTM!
copying my comment from #7521:
The only thing I can think of is disk space but the amount of disk consumed by the sparse headers is trivial compared to the original versions
IIRC the overhead was less than 2% of the original index header size in all cases which I've investigated.
Since they were experimental up until my PR we can probably just remove the flag, right? I'm not sure if we suggested that people try out the flag while it was still experimental.
they were enabled by default in 2.11 with # 6005, so there's at least one version running them. They've also been enabled for all store-gateway zones at GL since r253 (~August). I think it's safe to delete them.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Remove the experimental flag to enable / disable persistence of sparse index-headers since the only behavior now is to persist them. The sparse versions have resulted and a huge performance improvement during lazy loading and there's no reason to not enable this behavior.
Which issue(s) this PR fixes or relates to
See #7521 (comment)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.