Preparing release notes for 2.12 #7572

duricanikolic · 2024-03-10T14:51:25Z

What this PR does

This PR prepares release notes for Mimir 2.12.

Which issue(s) this PR fixes or relates to

Part of #7542

Checklist

Tests updated.
Documentation added.
CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
about-versioning.md updated with experimental features.

pstibrany · 2024-03-11T08:30:02Z

Let's also include a section about releasing new distroless image, and how it will become the default image soon. Please coordinate with @ying-jeanne and @jhesketh on details.

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

docs/sources/mimir/release-notes/v2.12.md

Co-authored-by: Ying WANG <74549700+ying-jeanne@users.noreply.github.com>

docs/sources/mimir/release-notes/v2.12.md

pstibrany · 2024-03-11T11:09:58Z

docs/sources/mimir/release-notes/v2.12.md

+- **The total number of OTLP requests** is tracked by the new `cortex_distributor_otlp_requests_total` metric.
+- **The total number of queries executed for a particular source (ingester vs. store-gateway)** is tracked by the new `cortex_querier_queries_storage_type_total` metric.
+- **The total number of chunks fetched from a store gateway** is tracked by the new `cortex_querier_query_storegateway_chunks_total` metric.


Interested readers can read all about these metrics in the changelog. Are these note-worthy in the release notes?

@pstibrany do you think we should just mention which metrics have been added without describing them, or do you think we should completely remove these entries?

It seems to me that new metrics like this are too small and not noteworthy-enough to be in the release notes. But ultimately, it's our PM's decision what to include in the release notes.

@zhehao-grafana WDYT about this? Should we mention all these metrics, or should we just leave them in CHANGELOG.md?

I will vote to keep them in the changlog

I have removed these 2 entries from the release notes. Thank you.

pstibrany · 2024-03-11T11:11:30Z

docs/sources/mimir/release-notes/v2.12.md

+
+- **The maximum number of tenant IDs that may be for a federated query** can be configured via the `-tenant-federation.max-tenants` CLI flag on query-frontends. By default, it is 0, meaning that the limit is disabled.
+- **Sharding of active series queries can be enabled** via the `-query-frontend.shard-active-series-queries` CLI flag on query-frontends.
+- **Timely head compaction** can be enabled via the `-blocks-storage.tsdb.timely-head-compaction-enabled` on ingesters. If enabled, the head compaction happens when the min block range can no longer be appended, without requiring 1.5x the chunk range worth of data in the head.


@jhalterman is it safe to mention this in release notes?

docs/sources/mimir/release-notes/v2.12.md

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

docs/sources/mimir/release-notes/v2.12.md

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

jdbaldry

I've submitted a review in the form of a PR: #7590

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Lint for style guidance Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Fixing lint errors Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com> Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> Co-authored-by: Đurica Yuri Nikolić <durica.nikolic@grafana.com>

duricanikolic · 2024-03-11T18:36:16Z

I've submitted a review in the form of a PR: #7590

I have merged @jdbaldry's recommendations.

docs/sources/mimir/release-notes/v2.12.md

pr00se · 2024-03-12T05:34:36Z

docs/sources/mimir/release-notes/v2.12.md

+  - `-query-frontend.additional-query-queue-dimensions-enabled` on the query-frontend.
+  - `-query-scheduler.additional-query-queue-dimensions-enabled` on the query-scheduler.
+
+- **Owned series tracking in ingesters** can be enabled via the `-ingester.track-ingester-owned-series` CLI flag.


@duricanikolic added owned series tracking experimental feature here

cc @pstibrany @jdbaldry

jhesketh · 2024-03-12T06:16:41Z

docs/sources/mimir/release-notes/v2.12.md

+
+## Features and enhancements
+
+- **Added `mimir-distroless` container image, built upon the `distroless` image**.


"the distroless image" isn't quite right as there are a number.

Built upon "a" distroless image perhaps. The specific one at the moment is gcr.io/distroless/static-debian12

Thank you @jhesketh.
I have updated the PR. Does this look better?

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

docs/sources/mimir/release-notes/v2.12.md

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

jdbaldry

Nice, new changes look good to me, thanks for incorporating my suggestions :)

colega

LGTM, thanks for incorporating my suggestions.

* Preparing release notes for 2.12 Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Adding mimir-distroless docker image entry Co-authored-by: Ying WANG <74549700+ying-jeanne@users.noreply.github.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Improve 2.11- to 2.12+ migration description Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Adding missing entries Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Lint release notes to better match the Grafana Labs style guides (#7590) * Lint for style guidance Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Fixing lint errors Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com> Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> Co-authored-by: Đurica Yuri Nikolić <durica.nikolic@grafana.com> * Add owned series tracking to experimental features * Fix relref link * Add distroless image name Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Remove unnecessary entries Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> Signed-off-by: Jack Baldry <jack.baldry@grafana.com> Co-authored-by: Ying WANG <74549700+ying-jeanne@users.noreply.github.com> Co-authored-by: Jack Baldry <jack.baldry@grafana.com> Co-authored-by: Patryk Prus <patryk.prus@grafana.com> (cherry picked from commit 6794cb4)

* Preparing release notes for 2.12 Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Adding mimir-distroless docker image entry Co-authored-by: Ying WANG <74549700+ying-jeanne@users.noreply.github.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Improve 2.11- to 2.12+ migration description Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Adding missing entries Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Lint release notes to better match the Grafana Labs style guides (#7590) * Lint for style guidance Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Fixing lint errors Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com> Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> Co-authored-by: Đurica Yuri Nikolić <durica.nikolic@grafana.com> * Add owned series tracking to experimental features * Fix relref link * Add distroless image name Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Remove unnecessary entries Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> Signed-off-by: Jack Baldry <jack.baldry@grafana.com> Co-authored-by: Ying WANG <74549700+ying-jeanne@users.noreply.github.com> Co-authored-by: Jack Baldry <jack.baldry@grafana.com> Co-authored-by: Patryk Prus <patryk.prus@grafana.com> (cherry picked from commit 6794cb4) Co-authored-by: Đurica Yuri Nikolić <durica.nikolic@grafana.com>

duricanikolic self-assigned this Mar 10, 2024

duricanikolic requested review from jdbaldry and a team as code owners March 10, 2024 14:51

Preparing release notes for 2.12

530146c

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

duricanikolic force-pushed the yuri/release-notes-2.12 branch from f083ff5 to 530146c Compare March 11, 2024 10:02

ying-jeanne reviewed Mar 11, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Show resolved Hide resolved

Adding mimir-distroless docker image entry

8e99b29

Co-authored-by: Ying WANG <74549700+ying-jeanne@users.noreply.github.com>

pstibrany reviewed Mar 11, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

pstibrany reviewed Mar 11, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

pstibrany reviewed Mar 11, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

pstibrany reviewed Mar 11, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

duricanikolic added 2 commits March 11, 2024 12:31

Fixing review findings

b52d7e9

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

Improve 2.11- to 2.12+ migration description

aadf237

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

duricanikolic requested a review from pstibrany March 11, 2024 12:08

dimitarvdimitrov reviewed Mar 11, 2024

View reviewed changes

Fixing review findings

3d47a4f

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

duricanikolic requested a review from dimitarvdimitrov March 11, 2024 14:52

jdbaldry reviewed Mar 11, 2024

View reviewed changes

duricanikolic and others added 2 commits March 11, 2024 18:59

Adding missing entries

be8d6fe

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

Add owned series tracking to experimental features

b855f2a

github-actions bot reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

Fix relref link

34c8d28

pr00se reviewed Mar 12, 2024

View reviewed changes

jhesketh reviewed Mar 12, 2024

View reviewed changes

Add distroless image name

b54c329

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

duricanikolic requested a review from jhesketh March 12, 2024 07:03

Remove unnecessary entries

33c0dc6

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

duricanikolic requested a review from zhehao-grafana March 12, 2024 07:10

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Show resolved Hide resolved

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Show resolved Hide resolved

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Show resolved Hide resolved

colega reviewed Mar 12, 2024

View reviewed changes

docs/sources/mimir/release-notes/v2.12.md Outdated Show resolved Hide resolved

Fixing review findings

6e98ab9

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

jdbaldry approved these changes Mar 12, 2024

View reviewed changes

duricanikolic requested a review from colega March 12, 2024 11:37

colega approved these changes Mar 12, 2024

View reviewed changes

duricanikolic merged commit 6794cb4 into main Mar 12, 2024
29 checks passed

duricanikolic deleted the yuri/release-notes-2.12 branch March 12, 2024 11:40

duricanikolic added release Release process backport release-2.12 labels Mar 12, 2024

grafanabot mentioned this pull request Mar 12, 2024

[release-2.12] Preparing release notes for 2.12 #7600

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preparing release notes for 2.12 #7572

Preparing release notes for 2.12 #7572

duricanikolic commented Mar 10, 2024

pstibrany commented Mar 11, 2024 •

edited

Loading

pstibrany Mar 11, 2024

duricanikolic Mar 11, 2024

pstibrany Mar 11, 2024

duricanikolic Mar 11, 2024

zhehao-grafana Mar 11, 2024

duricanikolic Mar 12, 2024

pstibrany Mar 11, 2024

jdbaldry left a comment

duricanikolic commented Mar 11, 2024

pr00se Mar 12, 2024

jhesketh Mar 12, 2024

duricanikolic Mar 12, 2024

jdbaldry left a comment

colega left a comment


		## Features and enhancements

		- Added `mimir-distroless` container image, built upon the `distroless` image.

Preparing release notes for 2.12 #7572

Preparing release notes for 2.12 #7572

Conversation

duricanikolic commented Mar 10, 2024

What this PR does

Which issue(s) this PR fixes or relates to

Checklist

pstibrany commented Mar 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdbaldry left a comment

Choose a reason for hiding this comment

duricanikolic commented Mar 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdbaldry left a comment

Choose a reason for hiding this comment

colega left a comment

Choose a reason for hiding this comment

pstibrany commented Mar 11, 2024 •

edited

Loading