Remove unused ingester metrics #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
commented
Jan 17, 2022
| @@ -272,7 +272,7 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |||
| .addPanel( | |||
| $.panel('Corruptions / sec') + | |||
| $.queryPanel([ | |||
| 'sum(rate(cortex_ingester_wal_corruptions_total{%s}[$__rate_interval]))' % $.jobMatcher($._config.job_names.ingester), | |||
| 'sum(rate(cortex_ingester_tsdb_wal_corruptions_total{%s}[$__rate_interval]))' % $.jobMatcher($._config.job_names.ingester), | |||
There was a problem hiding this comment.
This was a bug. It was querying the chunks storage WAL corruptions not the blocks storage one.
pracucci
commented
Jan 17, 2022
| // A small number of chunks per series - 10*(8^(7-1)) = 2.6m. | ||
| Buckets: prometheus.ExponentialBuckets(10, 8, 7), | ||
| }), | ||
| memSeries: promauto.With(r).NewGauge(prometheus.GaugeOpts{ |
There was a problem hiding this comment.
Not tracked in the CHANGELOG because this metric is still exported by the metric override we define in ingester.New().
pracucci
force-pushed
the
remove-unused-ingester-metrics
branch
2 times, most recently
from
31ef7a9
to
03b8f99
Compare
pracucci
commented
Jan 18, 2022
| @@ -188,7 +188,9 @@ func TestRuler_alerts(t *testing.T) { | |||
| cfg := defaultRulerConfig(t) | |||
|
|
|||
| r := newTestRuler(t, cfg, newMockRuleStore(mockRules)) | |||
| defer r.StopAsync() | |||
| t.Cleanup(func() { | |||
There was a problem hiding this comment.
I got this test failing in CI (flaky). It failed to delete the temp dir created by defaultRulerConfig() because not empty. I suspect the reason is that we don't wait for the ruler being stopped before we remove the dir. This change should fix it.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
remove-unused-ingester-metrics
branch
from
ada1537
to
0a8b2fb
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When we removed chunks storage support from ingester we forgot about removing metrics too. This PR does it.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]