Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused event logger #766

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

pracucci
Copy link
Collaborator

What this PR does:
I found an old event logger (introduced in Cortex PR 755) which is not used anymore. I'm deleting its code in this PR. No CHANGELOG entry cause it wasn't even documented.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I always believed @bboreham used this, so I'd wait for his comment.

@bboreham
Copy link
Contributor

I used it to make statistical analysis of data, e.g. what series are we rejecting from customers.
Recently we had a case where we didn't know what exemplars were arriving, and so this code could be brought into use again for that.
However it's true that it is not used outside of the chunks store right now.

@pracucci
Copy link
Collaborator Author

Ok, since it's dead code we can remove it for now.

@pracucci pracucci merged commit 5335457 into main Jan 18, 2022
@pracucci pracucci deleted the remove-unused-event-logging-support branch January 18, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants