Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.12] Get rid of -querier.prefer-streaming-chunks-from-ingesters #7661

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

grafanabot
Copy link
Contributor

Backport 8ed42e1 from #7639

* Get rid of querier.prefer-streaming-chunks-from-ingesters

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Fixing a failing test

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Fixing review findings

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Fixing failing tests

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Make lint happy

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Fixing review findings

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

---------

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
(cherry picked from commit 8ed42e1)
Copy link
Contributor

@duricanikolic duricanikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duricanikolic duricanikolic merged commit 4e9dfa0 into release-2.12 Mar 19, 2024
31 checks passed
@duricanikolic duricanikolic deleted the backport-7639-to-release-2.12 branch March 19, 2024 12:27
duricanikolic added a commit that referenced this pull request Mar 20, 2024
* Move -querier.minimize-ingester-requests from experimental to advanced (#7649)

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Get rid of -querier.prefer-streaming-chunks-from-ingesters (#7639) (#7661)

* Get rid of querier.prefer-streaming-chunks-from-ingesters

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Fixing a failing test

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Fixing review findings

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Fixing failing tests

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Make lint happy

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

* Fixing review findings

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

---------

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
(cherry picked from commit 8ed42e1)

Co-authored-by: Đurica Yuri Nikolić <durica.nikolic@grafana.com>

* [query-frontend] Close response body in request handler (#7654) (#7663)

* [query-frontend] Close response body in request handler (#7654)

* [query-frontend] close response body in request handler

(cherry picked from commit eaef377)

* changelog

* Update VERSIOn for release 2.12.0-rc.1 (#7671)

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>

---------

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Co-authored-by: Grot (@grafanabot) <43478413+grafanabot@users.noreply.github.com>
Co-authored-by: Felix Beuke <felix.j.beuke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants