Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: move userTSDB to dedicated source file #793

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

pracucci
Copy link
Collaborator

What this PR does:
I want to merge ingester.go and ingester_v2.go. However, before doing it, I propose to do the changes in this PR (as separate commits):

  1. Renamed user_state.go to metric_counter.go (to reflect what's inside)
  2. Move userTSDB to a dedicated file

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci changed the title Prepare ingester package for merging Chore: move userTSDB to dedicated source file Jan 18, 2022
Copy link
Contributor

@colega colega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm glad to see things moving into their own files.

@pracucci pracucci merged commit a3d16c2 into main Jan 19, 2022
@pracucci pracucci deleted the prepare-ingester-package-for-merging branch January 19, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants