ingest storage: record latency in replaying records #8176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pstibrany
approved these changes
May 24, 2024
pracucci
reviewed
May 29, 2024
| }), | ||
| consumeLatency: promauto.With(reg).NewHistogram(prometheus.HistogramOpts{ | ||
| Name: "cortex_ingest_storage_reader_consume_duration_seconds", | ||
| Help: "How long a request spent consuming a record batch from Kafka.", |
There was a problem hiding this comment.
[nit] Have you considered rename "request" to "batch" (or something similar) and maybe renaming the metric too? What we track here is the consumption of a batch of fetches.
Same comment applies to fetchWaitDuration metric
There was a problem hiding this comment.
I opened #8217
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I'm scoping work related to improving the replay speed in the new ingest storage. This PR adds some metrics which show where time is spent between processing batches and fetching them from kafka.