Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate TSDBState into Ingester #836

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Incorporate TSDBState into Ingester #836

merged 2 commits into from
Jan 24, 2022

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Jan 21, 2022 •
edited

What this PR does:

This moves TSDBState to Ingester and provides a common constructor for *Ingester in newIngester

@simonswine
Incorporate TSDBState into Ingester
022fa20 
This integrates the TSDBState into the ingester struct, as TSDB is now
the only available store engine in the ingesters.
@pracucci pracucci self-requested a review January 21, 2022 11:17
@pracucci pracucci mentioned this pull request Jan 21, 2022
Closed
@simonswine simonswine marked this pull request as ready for review January 21, 2022 11:35
@pracucci
Copy link
Collaborator

I think we can proudly say this PR fixes #5.

pracucci
pracucci approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Reviewing the changes to New() / NewForFlusher() / newIngester() is non trivial, so I hope I haven't missed anything. @replay could you take a double look, please?

replay
replay reviewed Jan 21, 2022
View reviewed changes
pkg/ingester/ingester.go Outdated Show resolved Hide resolved
replay
replay approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, I only had one minor suggestion

@pracucci pracucci merged commit 9c4c18e into main Jan 24, 2022
@pracucci pracucci deleted the 20220121_remove-tsdb-state branch January 24, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@replay replay replay approved these changes

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonswine @pracucci @replay