jsonnet: allow rollout-operator to be used as webhook endpoint #8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/oss-rollout-webhooks
branch
2 times, most recently
from
de4935a
to
fd54482
Compare
This change adds jsonnet configuration that allows the rollout-operator to be used as a validating or mutating webhook for changes to statefulsets. This is required to use the `no-downscale` or `prepare-downscale` labels on stateful components. This doesn't make any changes to the functionality used internally at Grafana or make anything more configurable. For example, this jsonnet still has the rollout-operator create self-signed certificates for the HTTPS webhook endpoints. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/oss-rollout-webhooks
branch
from
f622e14
to
832f587
Compare
|
Note that the test changes required for this seem to have uncovered a bug with the helm metamonitoring setup: namespaces set on objects that should not have namespaces. |
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
seizethedave
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This change adds jsonnet configuration that allows the rollout-operator to be used as a validating or mutating webhook for changes to statefulsets. This is required to use the
no-downscaleorprepare-downscalelabels on stateful components.This doesn't make any changes to the functionality used internally at Grafana or make anything more configurable. For example, this jsonnet still has the rollout-operator create self-signed certificates for the HTTPS webhook endpoints.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.