Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: this is all very opinionated, if you disagree ping me and we can change it 😄
the basic idea is that we only need two things:
as long as you set up those two, monaco will work.
so i think it's enough to have that.
lazy-loading i don't think we need, if the user of the library wants it, they can lazy-load the whole-thing themselves.
i also tried to change the npm-build-approach to be similar to how we do it in
@grafana/lezer-logql
.