Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update highlight for {{ }} pattern in string #3

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Update highlight for {{ }} pattern in string #3

merged 6 commits into from
Mar 8, 2022

Conversation

ivanahuckova
Copy link
Member

@ivanahuckova ivanahuckova commented Mar 8, 2022 •
edited

image

@ivanahuckova ivanahuckova requested review from gabor and removed request for gabor March 8, 2022 14:36
@ivanahuckova ivanahuckova changed the title Update highlight for {{ }} pattern in string WIP: Update highlight for {{ }} pattern in string Mar 8, 2022
@ivanahuckova ivanahuckova requested a review from gabor March 8, 2022 15:32
@ivanahuckova ivanahuckova changed the title WIP: Update highlight for {{ }} pattern in string Update highlight for {{ }} pattern in string Mar 8, 2022
@ivanahuckova
Copy link
Member Author

Ready!

@ivanahuckova
Copy link
Member Author

also if you approve, feel free to merge

gabor
gabor approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabor gabor merged commit 0fe62bf into main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor gabor gabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanahuckova @gabor