Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve time duration regex #4

Merged
merged 2 commits into from
Feb 23, 2023
Merged

improve time duration regex #4

merged 2 commits into from
Feb 23, 2023

Conversation

svennergr
Copy link
Contributor

Based on https://prometheus.io/docs/prometheus/latest/querying/basics/#time-durations we can also have ms as a duration. The current regex does not fit this, as seen in this image:

image

The new regex looks like it fits well: https://regex101.com/r/VAEudi/1

@svennergr svennergr added the bug Something isn't working label Feb 22, 2023
@svennergr svennergr self-assigned this Feb 22, 2023
ivanahuckova
ivanahuckova approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svennergr svennergr merged commit 83a1884 into main Feb 23, 2023
@svennergr svennergr deleted the svennergr/fix-time-regex branch February 23, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

@gabor gabor Awaiting requested review from gabor

Assignees

@svennergr svennergr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svennergr @ivanahuckova