close the mtr channel from the sending location #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem
reviewed
Jul 29, 2021
Comment on lines
+65
to
+69
| _, isOpen := <-ch | ||
| if !isOpen { | ||
| mu.Unlock() | ||
| return | ||
| } |
There was a problem hiding this comment.
I think the same logic is needed above on lines 47-49
I find it a little odd that a channel is returned on line 40 to be passed to m on lines 51 and 74.
I think what this should do is return a read only channel (<- chan struct{} instead of just chan struct{}) from mtr.NewMTR, and store the channel in the structure, and then close it before Run returns. Since Run would have access to the channel, it wouldn't need it as an argument.
| render(m) | ||
| mu.Unlock() | ||
| } | ||
| }(ch) | ||
| m.Run(ch, COUNT) | ||
| close(ch) |
There was a problem hiding this comment.
Unless I'm missing something, I think this has no effect, as Run calls discover which closes the channel as the last thing it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.