add the option to run with a context to control timeouts #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdubrock
commented
Aug 4, 2021
| @@ -1,13 +1,16 @@ | |||
| module github.com/tonobo/mtr | |||
|
|
|||
| go 1.16 | |||
There was a problem hiding this comment.
running go mod tidy did this, I'm not sure if that's what we want or what
rdubrock
commented
Aug 4, 2021
| case <-time.After(m.interval): | ||
| unknownHopsCount := 0 | ||
|
|
||
| ttlLoop: |
There was a problem hiding this comment.
I'm not sure what the opinions are on loop labels. We need to break the loop from inside the select, and this seemed the most convenient way to do it, but I'm not sure if that's considered a code smell or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
RunWithContextfunctionRunandRunWithContextmethods to return an errormaxUnknownHopsvalue is reached