Handle parsing errors #5
Conversation
mem
force-pushed
the
handle_parsing_errors
branch
from
534a109
to
11ddf57
Compare
There was a problem hiding this comment.
LGTM.
I had been thinking about why is this failing, in our case, very rarely.
Maybe it receives a truncated packet?
I suspect the problem could also be related the bytes.Index call, maybe the sent[:4] bytes are not as random as we would like them to be and occasionally it finds an earlier match in the IP header?
Just wondering if it's worth to continue scanning the packet for those bytes.
Modify the logic so that it's more robust against errors and malformed packets. Also try to make sure that we are matching against the correct bytes in the response. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
force-pushed
the
handle_parsing_errors
branch
from
11ddf57
to
d4e77dd
Compare
Thanks for going over that. I reworked more of the logic in those functions. I think it should handle error conditions better in this way, and it should avoid spurious matches. |
This implementation has the problem that it never times out.
Signed-off-by: Marcelo E. Magallon marcelo.magallon@grafana.com