shift info push notification tweaks #2024
Assignees
Labels
feature request
New feature or request
good first issue
Good for newcomers
involved:Frontend
part:schedules
Comments
|
Text suggestion: Your on-call shift starts in 10 min |
|
Closing because OnCall version & labeling is missing. |
Dieterbe
added
feature request
joeyorlando
added a commit
that referenced
this issue
Jun 14, 2023
…g on call push notification text (#2131) # What this PR does - add user locale field to mobile app user settings table + add a test that sends `PATCH` requests to this endpoint - change "you're going on call" push notification text to include localized shift time. The general format is now: ```python f"You're going on call in {time_until_going_oncall} for schedule {schedule.name}, {formatted_shift}" ``` - `time_until_going_oncall` is a "human-readable" format of the time until the start) - `schedule.name` is self-explanatory - `formatted_shift` this depends on the shift. If the shift starts and ends on the same day, the format will be "HH:mm - HH:mm". Otherwise, if the shift starts and ends on different days, the format will be "YYYY-MM-DD HH:mm - YYYY-MM-DD HH:mm". **Note** that all datetime related formatting will use the new `locale` field that we are now storing in the mobile app user settings table. If no locale is yet present we will fallback to "en" ## Which issue(s) this PR fixes closes #2024 grafana/oncall-mobile-app#187 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
can we tweak the design of the upcoming shift notification to say something like:
for comparison, google calendar notification:
version v1.2.31
The text was updated successfully, but these errors were encountered: