Add acknowledged, resolved user information on webhook payload #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added the details separately outside of the alertgroup since we use the same alert group serializer for the public API response. For integration details also we have followed the similar pattern. |
joeyorlando
changed the title
joeyorlando
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
LGTM 👍 thanks again for your continued contributions @ravishankar15
joeyorlando
added
pr:no public docs
joeyorlando
reviewed
Apr 10, 2024
There was a problem hiding this comment.
actually, one last minor ask. Do you mind updating the documentation here?
once that's squared away I will go ahead and merge ✌️
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
auto-merge was automatically disabled
April 16, 2024 17:56
Merge queue setting changed
matiasb
force-pushed
the
webhook-payload-add-user-detail
branch
from
5301067
to
d417b80
Compare
alyssawada
approved these changes
Apr 25, 2024
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds acknowledged and resolved user information to the web hook payload
Which issue(s) this PR closes
Closes #4126
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.